You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#1106 seems to have broken default DirLoader behavior. This PR attempts to fix that.
$ tree foo
foo
└── test dir
├── another test dir
└── file.txt
# before
$ target-shell dir://foo
2026-01-08T14:46:56.840760Z [error ] dir://foo: Failed to load target with loader DirLoader('foo') [dissect.target.target]
2026-01-08T14:46:56.840922Z [error ] Error opening shell: Failed to find any loader for targets: ['dir://foo'] [dissect.target.tools.shell]
$
# after
$ target-shell dir://foo
2026-01-08T14:46:11.536849Z [warning ] <Target foo>: Failed to find OS plugin, falling back to default [dissect.target.target]
foo:/$
Also DirLoader detection seems broken (target-shell foo does not work), but that might be intentional?
This doesn't seem to work pre-#1106 either, because your sample directory does not have a valid OS structure. I think the changes to Target.open (#1265) now skip the detection when you use URI patterns.
Even if you skip the detection, the "issue" is that find_entry_path will return None because of the aforementioned issue that the directory does not have any OS structure to it. I guess the intended change is to allow usage of the directory loader on arbitrary directories if you specify the URI?
Also DirLoader detection seems broken (target-shell foo does not work), but that might be intentional?
That's intentional, it should only work on directories that have a valid OS structure. Otherwise we can't safely/sanely do the directory iteration in Target.open_all.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1106 seems to have broken default DirLoader behavior. This PR attempts to fix that.
Also
DirLoaderdetection seems broken (target-shell foodoes not work), but that might be intentional?